[IR#59] - close_avatar_dropdown_on_item_click #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I know that I renamed and moved some file for some reasons and it makes hard for me to review PR - in future I will consider that and use 'stash changes' - then rename file - then 'restore'
to be consistent with AvatarDropdown
Also I created store to get access to dropdown open / close functions Also I improved avatarDropdown hook
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nicitaacom
changed the title
nicitaacom
changed the title
nicitaacom
changed the title
nicitaacom
changed the title
nicitaacom
changed the title
nicitaacom
changed the title
nicitaacom
commented
Nov 8, 2023
| @@ -1,11 +1,7 @@ | |||
| import Link from "next/link" | |||
There was a problem hiding this comment.
This commit should be named as chore: support button incapsulated
chore - for update that doesn't affect on user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
1. Overflow hidden when modal isOpen improved
Now I have this scroll and this is better - also I improved scroll when modal isOpen - now I see no jumping left and right from navbar and I see the same background as it was before and I block user to scroll if modal isOpen
2. Close avatarDropdown on DropdownItem click
Just logic to close dropdown when I click on dropdown item
Result
https://streamable.com/94nbby
Github task - https://github.com/users/nicitaacom/projects/5?pane=issue&itemId=43896841
This task done - delete this branch and move task to 'Done'