Fixes and extensions to surface albedo model #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Moved data around: spectral file Oak, thermo ncdfs, literature values. New folder for notebooks which aren't tutorials (misc). Updated cfgs and readme files.
nichollsh
added a commit
that referenced
this pull request
Oct 30, 2024
Fixes and extensions to surface albedo model
nichollsh
added a commit
that referenced
this pull request
Oct 30, 2024
Fixes and extensions to surface albedo model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old surface albedo model was not working properly. This has now been fixed, with the addition of wavelength-dependent data in
res/.The configuration file needs to specify the
surface_material. This can either be a "blackbody" or the path to a file containing wavelength-dependent albedo data. In the former case,albedo_s(a float) needs to be supplied.There is a new test for this in
test/runtests.jl, since I had some trouble getting this to work properly.Closes #56 as completed.
Note that this does not include surface emissivity, which will need to be handled separately.