Fixes to chemistry following thermo changes #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nichollsh
added a commit
that referenced
this pull request
Oct 30, 2024
Fixes to chemistry following thermo changes
nichollsh
added a commit
that referenced
this pull request
Oct 30, 2024
Fixes to chemistry following thermo changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following changes to the thermodynamics in AGNI, coupling with FastChem was broken. This has now been corrected, with some improvements enabled by the thermo updates.
Note that FC can still fail at small temperatures, which isn't surprising. AGNI checks for this and can limit T(p) >= some value, to prevent issues. If you want, this can be thought of some rough approximation of kinetic quenching.
Version bumped to 0.5.2