Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for better getting started experience #593

Merged

Conversation

WayneDroid
Copy link
Collaborator

What does this Pull Request accomplish?

added "Getting Started" section in README.

Why should this Pull Request be merged?

Purpose of Getting Started is a basic introduction of NI DAQ to new customers or customers who want to use nidaqmx-python for their program development.

What testing has been done?

N/A

Copy link
Collaborator

@charitylxy charitylxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with Suggestions :)

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Show resolved Hide resolved
README.rst Show resolved Hide resolved
README.rst Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Show resolved Hide resolved
@WayneDroid WayneDroid requested a review from hongloonwong June 11, 2024 07:06
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Show resolved Hide resolved
@WayneDroid
Copy link
Collaborator Author

@bkeryan @zhindes is there any update / rework needed for this PR? If the content is okay, I am going to send a copy of html files to tech writer to review. However, the tech writer may not be able to come back to me by this Friday. I want to propose, if the content is okay, can we merge this PR?

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
@zhindes
Copy link
Collaborator

zhindes commented Jun 18, 2024

@bkeryan @zhindes is there any update / rework needed for this PR? If the content is okay, I am going to send a copy of html files to tech writer to review. However, the tech writer may not be able to come back to me by this Friday. I want to propose, if the content is okay, can we merge this PR?

Looks good to me to get in now. I found two minor issues with the latest changes to resolve.

Copy link
Collaborator

@bkeryan bkeryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions

README.rst Outdated Show resolved Hide resolved
@WayneDroid WayneDroid merged commit 815705e into ni:master Jun 19, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants