Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup documentation conf.py #569

Merged
merged 5 commits into from
May 9, 2024
Merged

cleanup documentation conf.py #569

merged 5 commits into from
May 9, 2024

Conversation

zhindes
Copy link
Collaborator

@zhindes zhindes commented Apr 22, 2024

What does this Pull Request accomplish?

  • Remove auto-generated sphinx documentation comments
  • Pull documentation config from pyproject.toml
  • Reverse release/version - we had them backwards
  • Add Brad as a maintainer in pyproject

Why should this Pull Request be merged?

Less manual steps when updating version. Less copy/pasta.

What testing has been done?

Built documentation. It looks good.

Copy link

github-actions bot commented Apr 22, 2024

Test Results

    34 files  ±0      34 suites  ±0   46m 25s ⏱️ -16s
 2 248 tests ±0   1 910 ✅ ±0    338 💤 ±0  0 ❌ ±0 
39 690 runs  ±0  34 134 ✅ ±0  5 556 💤 ±0  0 ❌ ±0 

Results for commit c2504fc. ± Comparison against base commit 8a96d34.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@bkeryan bkeryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
poetry.lock Show resolved Hide resolved
@zhindes zhindes force-pushed the users/zhindes/cleanup_docs branch from 74d8e14 to 458d2b8 Compare May 9, 2024 17:41
@zhindes zhindes merged commit 1bc5df5 into master May 9, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants