Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AI create channel tests #485

Merged
merged 5 commits into from
Feb 2, 2024
Merged

Conversation

zhindes
Copy link
Collaborator

@zhindes zhindes commented Feb 2, 2024

What does this Pull Request accomplish?

This adds a test per non-TEDS AI create channel method to validate that they can successfully be used. There is a small amount of functional validation that parameters are properly being passed through the layers of Python and underlying driver API.

Why should this Pull Request be merged?

This will give us confidence that we haven't broken anything as we refactor parts of the Python and driver stack. This also helped uncover some usability issues with the Python API:

What testing has been done?

All existing unit tests pass, skip,or xfail as before. New unit tests:

$ poetry run pytest -rs -k test_ai_channel
=============================== test session starts ===============================
platform win32 -- Python 3.10.10, pytest-7.4.2, pluggy-1.3.0
rootdir: C:\dev\nidaqmx-python
configfile: pyproject.toml
testpaths: tests
plugins: cov-4.1.0, mock-3.11.1
collected 1379 items / 1239 deselected / 140 selected

tests\component\_task_modules\channels\test_ai_channel.py .................. [ 12%]
............................................................................ [ 67%]
............................................                                 [ 98%]
tests\legacy\test_channels.py ..                                             [100%]

====================== 140 passed, 1239 deselected in 3.50s =======================

tests/component/_task_modules/channels/test_ai_channels.py Outdated Show resolved Hide resolved
tests/max_config/nidaqmxMaxConfig.ini Outdated Show resolved Hide resolved
tests/conftest.py Show resolved Hide resolved
tests/max_config/nidaqmxMaxConfig.ini Show resolved Hide resolved
tests/component/_task_modules/channels/test_ai_channels.py Outdated Show resolved Hide resolved
tests/component/_task_modules/channels/test_ai_channels.py Outdated Show resolved Hide resolved
tests/component/_task_modules/channels/test_ai_channels.py Outdated Show resolved Hide resolved
tests/component/_task_modules/channels/test_ai_channels.py Outdated Show resolved Hide resolved
tests/component/_task_modules/channels/test_ai_channels.py Outdated Show resolved Hide resolved
tests/component/_task_modules/channels/test_ai_channels.py Outdated Show resolved Hide resolved
@zhindes zhindes changed the title Users/zhindes/create channel tests Add AI create channel tests Feb 2, 2024
Copy link

github-actions bot commented Feb 2, 2024

Test Results

    30 files  ±    0      30 suites  ±0   34m 10s ⏱️ +26s
 1 380 tests +  138   1 150 ✅ +   88    230 💤 + 50  0 ❌ ±0 
21 330 runs  +2 070  17 960 ✅ +1 320  3 370 💤 +750  0 ❌ ±0 

Results for commit 6aafa5d. ± Comparison against base commit 908cebf.

♻️ This comment has been updated with latest results.

@zhindes zhindes requested a review from bkeryan February 2, 2024 22:22
@zhindes zhindes force-pushed the users/zhindes/create_channel_tests branch from 6aafa5d to c536f53 Compare February 2, 2024 23:08
@zhindes zhindes enabled auto-merge (squash) February 2, 2024 23:09
@zhindes zhindes merged commit a6b070d into master Feb 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants