Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Shunt Cal API support for nidaqmx-python #469

Merged
merged 13 commits into from
Jan 15, 2024

Conversation

charitylxy
Copy link
Collaborator

@charitylxy charitylxy commented Jan 5, 2024

What does this Pull Request accomplish?

This PR adds Shunt Calibration API support for the following functions in nidaqmx-python:
DAQmxPerformStrainShuntCalEx
DAQmxPerformBridgeShuntCalEx

Why should this Pull Request be merged?

It provide support for Shunt Calibration in python.

What testing has been done?

Regression tests have been added and all tests passed in local machine.
image

generated/nidaqmx/task.py Outdated Show resolved Hide resolved
src/handwritten/task.py Outdated Show resolved Hide resolved
@charitylxy charitylxy marked this pull request as ready for review January 8, 2024 06:46
@charitylxy charitylxy requested a review from zhindes January 8, 2024 07:13
generated/nidaqmx/constants.py Outdated Show resolved Hide resolved
generated/nidaqmx/constants.py Outdated Show resolved Hide resolved
src/handwritten/task.py Outdated Show resolved Hide resolved
src/handwritten/task.py Outdated Show resolved Hide resolved
src/handwritten/task.py Outdated Show resolved Hide resolved
tests/component/test_task.py Outdated Show resolved Hide resolved
src/handwritten/task.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@zhindes zhindes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brad covered everything quite well. I added some replies to his comments.

generated/nidaqmx/_grpc_interpreter.py Show resolved Hide resolved
Copy link
Collaborator

@zhindes zhindes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

generated/nidaqmx/constants.py Show resolved Hide resolved
generated/nidaqmx/constants.py Outdated Show resolved Hide resolved
src/handwritten/task.py Outdated Show resolved Hide resolved
src/handwritten/task.py Outdated Show resolved Hide resolved
src/handwritten/task.py Outdated Show resolved Hide resolved
tests/component/test_task.py Outdated Show resolved Hide resolved
src/handwritten/task.py Outdated Show resolved Hide resolved
tests/component/test_task.py Outdated Show resolved Hide resolved
tests/component/test_task.py Show resolved Hide resolved
tests/component/test_task.py Outdated Show resolved Hide resolved
@charitylxy charitylxy requested a review from bkeryan January 11, 2024 06:24
Copy link
Collaborator

@bkeryan bkeryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions

tests/component/test_task.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@charitylxy charitylxy merged commit 8f1b610 into ni:master Jan 15, 2024
15 of 16 checks passed
@charitylxy charitylxy deleted the users/charitylxy/shunt-cal branch February 21, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose Shunt Calibration and Offset Nulling Calibration Functions in Bindings
3 participants