Skip to content

Commit

Permalink
Address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
charitylxy committed Jan 15, 2024
1 parent 8ad3d27 commit f0facf8
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
4 changes: 3 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ All notable changes to this project will be documented in this file.
* ### Merged Pull Requests
* ...
* ### Major Changes
* Fix naming issues. `AAND_B` is now `A_AND_B`, `R_1` is now `R1`, `R_2` is now `R2`, `R_3` is now `R3` and `R_4` is now `R4`.
* Add support for strain calibration (offset nulling and shunt calibration)
* Fix naming issues:
* Rename `ShuntCalSelect.AAND_B` to `A_AND_B`.
* ### Known Issues
* ...

Expand Down
8 changes: 4 additions & 4 deletions tests/component/test_task.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def test___perform_bridge_shunt_cal___no_errors(
skip_unsupported_channels,
)
except nidaqmx.DaqError as e:
if e.error_code != -201493:
if e.error_code != DAQmxErrors.SHUNT_CAL_FAILED_OUT_OF_RANGE:
raise


Expand All @@ -91,7 +91,7 @@ def test___perform_bridge_shunt_cal_default___no_errors(
try:
ai_bridge_task.perform_bridge_shunt_cal(ai_bridge_task.channels.name)
except nidaqmx.DaqError as e:
if e.error_code != -201493:
if e.error_code != DAQmxErrors.SHUNT_CAL_FAILED_OUT_OF_RANGE:
raise


Expand Down Expand Up @@ -126,7 +126,7 @@ def test___perform_strain_shunt_cal___no_errors(
skip_unsupported_channels,
)
except nidaqmx.DaqError as e:
if e.error_code != -201493:
if e.error_code != DAQmxErrors.SHUNT_CAL_FAILED_OUT_OF_RANGE:
raise


Expand All @@ -140,5 +140,5 @@ def test___perform_strain_shunt_cal_default___no_errors(
try:
ai_strain_gage_task.perform_strain_shunt_cal(ai_strain_gage_task.channels.name)
except nidaqmx.DaqError as e:
if e.error_code != -201493:
if e.error_code != DAQmxErrors.SHUNT_CAL_FAILED_OUT_OF_RANGE:
raise

0 comments on commit f0facf8

Please sign in to comment.