Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page for switching from GOV.UK prototype kit #26

Merged
merged 13 commits into from
Oct 26, 2024
Merged

Page for switching from GOV.UK prototype kit #26

merged 13 commits into from
Oct 26, 2024

Conversation

vickytnz
Copy link
Contributor

@vickytnz vickytnz commented Oct 21, 2024 •
edited
Loading

Description

Version of #6

How to page

how-to page with 'advanced usage - switching from the govuk prototype kit

Switching page

switching from the govuk prototype kit page

Checklist

  • Tested against our testing policy (Resolution, Browser & Accessibility)
  • CHANGELOG entry

@frankieroberto frankieroberto temporarily deployed to nhs-prototyp-govuk-prot-lqobn8 October 21, 2024 17:57 Inactive
@vickytnz vickytnz linked an issue Oct 21, 2024 that may be closed by this pull request
Add guidance for anyone switching to the NHS prototype kit from the GOV.UK prototype kit #6
Closed
@frankieroberto frankieroberto temporarily deployed to nhs-prototyp-govuk-prot-lqobn8 October 25, 2024 19:42 Inactive
@vickytnz
Copy link
Contributor Author

vickytnz commented Oct 25, 2024 •
edited
Loading

I have made an improved dos and don'ts version (which was fun)

lversion with dos and don'ts

A few niggling things:

  • It could be that in fact all of the dos and don'ts can be in one list
  • the 'do not copy' probably isn't strictly true - it's more that if someone does it may not work correctly and they may need to copy extra things like CSS and source code

@vickytnz vickytnz mentioned this pull request Oct 25, 2024
Closed
frankieroberto
frankieroberto reviewed Oct 25, 2024
View reviewed changes
Copy link
Contributor

@frankieroberto frankieroberto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Left some suggested changes and additions.

app/views/how-tos/switching-from-govuk-prototype-kit.html Outdated Show resolved Hide resolved
app/views/how-tos/switching-from-govuk-prototype-kit.html Outdated Show resolved Hide resolved
app/views/how-tos/switching-from-govuk-prototype-kit.html Outdated Show resolved Hide resolved
app/views/how-tos/switching-from-govuk-prototype-kit.html Outdated Show resolved Hide resolved
app/views/how-tos/switching-from-govuk-prototype-kit.html Outdated Show resolved Hide resolved
app/views/how-tos/switching-from-govuk-prototype-kit.html Outdated Show resolved Hide resolved
app/views/how-tos/switching-from-govuk-prototype-kit.html Outdated Show resolved Hide resolved
app/views/how-tos/switching-from-govuk-prototype-kit.html Outdated Show resolved Hide resolved
app/views/how-tos/switching-from-govuk-prototype-kit.html Show resolved Hide resolved
app/views/how-tos/switching-from-govuk-prototype-kit.html Outdated Show resolved Hide resolved
@frankieroberto frankieroberto temporarily deployed to nhs-prototyp-govuk-prot-lqobn8 October 26, 2024 12:53 Inactive
@frankieroberto frankieroberto temporarily deployed to nhs-prototyp-govuk-prot-lqobn8 October 26, 2024 12:54 Inactive
@frankieroberto frankieroberto temporarily deployed to nhs-prototyp-govuk-prot-lqobn8 October 26, 2024 12:56 Inactive
@vickytnz
Copy link
Contributor Author

New version based on amends

version with new dos and don'ts

@frankieroberto frankieroberto temporarily deployed to nhs-prototyp-govuk-prot-lqobn8 October 26, 2024 13:24 Inactive
frankieroberto
frankieroberto approved these changes Oct 26, 2024
View reviewed changes
Copy link
Contributor

@frankieroberto frankieroberto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I reckon get this merged and deployed? We could see if we can get some feedback from any recent NHS joiners who have experience with the GOVUK kit?

@frankieroberto frankieroberto temporarily deployed to nhs-prototyp-govuk-prot-lqobn8 October 26, 2024 14:16 Inactive
@vickytnz
Copy link
Contributor Author

Nice! I reckon get this merged and deployed? We could see if we can get some feedback from any recent NHS joiners who have experience with the GOVUK kit?

Yeah, I think that this is ready for sharing with:

  1. people who have just switched from GOV.UK to NHS prototype kit to sense check
  2. potential users - those in the GOV.UK prototype kit community who could be a good test case of people that might just want to dive in without going through all of the details (I guess there is still a hypothesis as to if this is needed and in how much detail - my hunch is that this is about right).

@frankieroberto
Copy link
Contributor

@vickytnz hit merge when you’re ready! 🚢

@vickytnz vickytnz merged commit 7d70f0d into main Oct 26, 2024
2 checks passed
@vickytnz vickytnz deleted the govuk-prototype-kit-changes branch October 26, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankieroberto frankieroberto frankieroberto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
NHS prototype kit project board (info in 'project details')
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add guidance for anyone switching to the NHS prototype kit from the GOV.UK prototype kit
2 participants
@vickytnz @frankieroberto