-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tutorial for creating a basic prototype (based on GOV.UK one) #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A great start!
I think we’ll need to add some css for code blocks and inline code examples as those are currently quite hard to spot (just the font changes).
app/views/how-tos/make-first-prototype/open-prototype-in-editor.html
Outdated
Show resolved
Hide resolved
app/views/how-tos/make-first-prototype/let-user-change-answers.html
Outdated
Show resolved
Hide resolved
app/views/how-tos/make-first-prototype/link-index-page-start-page.html
Outdated
Show resolved
Hide resolved
app/views/ineligible.html
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presumably these pages should be deleted before we merge, and just used to test it out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, exactly, it's particularly since we're using code examples and also doing screenshots - this makes it easier to debug (I also realise i haven't tested the branching)
Co-authored-by: Frankie Roberto <[email protected]>
Co-authored-by: Frankie Roberto <[email protected]>
Co-authored-by: Frankie Roberto <[email protected]>
…age.html Co-authored-by: Frankie Roberto <[email protected]>
…r.html Co-authored-by: Frankie Roberto <[email protected]>
Co-authored-by: Frankie Roberto <[email protected]>
Co-authored-by: Frankie Roberto <[email protected]>
…r.html Co-authored-by: Frankie Roberto <[email protected]>
…r.html Co-authored-by: Frankie Roberto <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes made base on Frankie's comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Would you mind doing indenting on all the nested HTML just to make it easier to read? A code formatter like prettier should be able to do it for you automatically.
Also the files used to test the tutorial itself (magical-powers.html
etc) should all be deleted.
Then perhaps we get another pair of eyes on it (@edwardhorsford?), and see if we can find someone to test it by actually following the tutorial?
Co-authored-by: Frankie Roberto <[email protected]>
Co-authored-by: Frankie Roberto <[email protected]>
Co-authored-by: Frankie Roberto <[email protected]>
Co-authored-by: Frankie Roberto <[email protected]>
Co-authored-by: Frankie Roberto <[email protected]>
Co-authored-by: Frankie Roberto <[email protected]>
Co-authored-by: Frankie Roberto <[email protected]>
Co-authored-by: Frankie Roberto <[email protected]>
Current status is that this is in a good place for review:
|
Co-authored-by: Frankie Roberto <[email protected]>
Need to link from the install guide - will make separate pull request. |
Description
This is probably not quite ready to go straight to deployment because it has:
It does have a full worked example bringing together the content into a guide.
Example of translated screenshots that are used in the examples
It's also shown that some of the design system components can do with tweaking, for example:
Checklist
Resolves #17