Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #176

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Update README.md #176

merged 1 commit into from
Dec 10, 2024

Conversation

sarawilcox
Copy link
Contributor

Bring into line with content style guide, esp re use of double quotation marks.

@vickytnz , are you OK with this?

One question I had was about title tabs being different from H1s. Normally we'd make them the same, except where, for example, there are issues about data privacy.

Bring into line with content style guide, esp re use of double quotation marks.
@frankieroberto frankieroberto temporarily deployed to nhs-prototyp-sarawilcox-cjsgqb December 10, 2024 14:03 Inactive
@frankieroberto
Copy link
Contributor

@sarawilcox:

One question I had was about title tabs being different from H1s. Normally we'd make them the same, except where, for example, there are issues about data privacy.

Yeah, I’d agree with this too. I wonder if we’ve accidentally let the 2 titles differ rather than it be a deliberate thing?

@vickytnz
Copy link
Contributor

vickytnz commented Dec 10, 2024

yeah this is accidental - normally i set up page templates so that one variable updates both rather than forget about it (in fact you can see it in any of the min-guides i've been creating for the guidance).

Quotes is just a personal confusion for me as I got taught the American process for quotes growing up and so tend to revert back to it particularly when looking at code which is often American.

@vickytnz vickytnz merged commit 7f7a984 into main Dec 10, 2024
4 checks passed
@vickytnz vickytnz deleted the sarawilcox-patch-1 branch December 10, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants