Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update page template examples #1975

Closed
wants to merge 7 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# NHS digital service manual Changelog

## Unreleased
:wrench: **Maintenance**
- Update page template examples to make the default example size l and inside the grid system

## 6.3.0 – 17 April 2024
:new: **New features**
- Add page on new accessibility requirements: WCAG 2.2
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
{% block content %}
<div class="nhsuk-grid-row">
<div class="nhsuk-grid-column-two-thirds">
<h1>
<h1 class="nhsuk-heading-xl">
Content page template
</h1>
</div>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
{% extends "includes/template.njk" %}

{% block content %}
<h1>Default page template</h1>
<div class="nhsuk-grid-row">
<div class="nhsuk-grid-column-two-thirds">
<h1 class="nhsuk-heading-l">
Default page template
</h1>
</div>
</div>
{% endblock %}
7 changes: 5 additions & 2 deletions app/views/design-system/styles/page-template/index.njk
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@

<p>This page template combines boilerplate markup and <a href="/design-system/components">components</a> needed for a content page and a transactional page. This includes:</p>
<ul>
<li>JavaScript that adds a <code>.js-enabled</code> class, which components with JavaScript behaviour need</li>
<li>JavaScript that adds a <code>js-enabled</code> class, which components with JavaScript behaviour need</li>
<li>the <a href="/design-system/components/skip-link">skip link</a>, <a href="/design-system/components/header">header</a> and <a href="/design-system/components/footer">footer</a> components</li>
<li>favicons, and other page metadata</li>
</ul>
Expand Down Expand Up @@ -78,6 +78,8 @@

<p>The content page template example includes navigation and search in the <a href="/design-system/components/header">header</a> and a <a href="/design-system/components/back-link">breadcrumbs</a> component.</p>

<p>We recommend you use a larger <code>{{ "<h1>" | escape }}</code> heading size using the <code>nhsuk-heading-xl</code> modifier class. Content pages may need more heading levels and the larger size makes the heading hierarchy clearer.

{{ designExample({
group: "styles",
item: "page-template",
Expand All @@ -98,7 +100,8 @@
showArguments: false
}) }}

<p>Vertical padding is reduced on transactional services using the <code>.nhsuk-main-wrapper--s</code> modifier class. We also recommended you use a smaller page heading size using the <code>.nhsuk-heading-l</code> modifier class.</p>
<p>Vertical padding is reduced on transactional services using the <code>nhsuk-main-wrapper--s</code> modifier class.
We also recommend you use a smaller <code>{{ "<h1>" | escape }}</code> heading size using the <code>nhsuk-heading-l</code> modifier class.

<h2 id="changing-template-content">Changing template content</h2>

Expand Down