Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade nhsuk frontend version to v9.0.1 #356

Merged
merged 15 commits into from
Oct 11, 2024
Merged

Upgrade nhsuk frontend version to v9.0.1 #356

merged 15 commits into from
Oct 11, 2024

Conversation

frankieroberto
Copy link
Contributor

@frankieroberto frankieroberto commented Sep 19, 2024 •
edited
Loading

Updates NHS.UK Frontend to version 9.0.1 plus associated changes.

Checklist

  • CHANGELOG entry

@frankieroberto
Copy link
Contributor Author

@anandamaryon1 @edwardhorsford @paulrobertlloyd think I've caught all the updates needed, but let me know if you spot anything I’ve missed!

@edwardhorsford edwardhorsford mentioned this pull request Sep 20, 2024
Closed
@anandamaryon1
Copy link
Contributor

Thanks @frankieroberto

Updated the Check answers page template to conform with the latest headings guidance.

anandamaryon1
anandamaryon1 previously approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@anandamaryon1 anandamaryon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can't think of anything else that needs amending. (But will appreciate other's taking a look)

@frankieroberto
Copy link
Contributor Author

@anandamaryon1 thanks - I didn’t check all the example and docs pages.

@edwardhorsford edwardhorsford changed the title Upgrade nhsuk frontend version Upgrade nhsuk frontend version to v9.0.0 Sep 27, 2024
edwardhorsford
edwardhorsford requested changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@edwardhorsford edwardhorsford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Have run locally and it seems to work ok.

I think the changelog could be more extensive as this is probably a breaking change - we'll need to release v9 of the prototype kit.

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
edwardhorsford
edwardhorsford reviewed Oct 9, 2024
View reviewed changes
app.js Outdated Show resolved Hide resolved
edwardhorsford
edwardhorsford previously approved these changes Oct 11, 2024
View reviewed changes
@frankieroberto frankieroberto changed the title Upgrade nhsuk frontend version to v9.0.0 Upgrade nhsuk frontend version to v9.0.1 Oct 11, 2024
@frankieroberto frankieroberto merged commit 776f1d1 into main Oct 11, 2024
2 checks passed
@frankieroberto frankieroberto deleted the upgrade-nhsuk-frontend-version branch October 11, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandamaryon1 anandamaryon1 anandamaryon1 left review comments

@edwardhorsford edwardhorsford edwardhorsford approved these changes

@roshaanbajwa roshaanbajwa Awaiting requested review from roshaanbajwa

@paulrobertlloyd paulrobertlloyd Awaiting requested review from paulrobertlloyd

Assignees
No one assigned
Labels
💥 breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frankieroberto @anandamaryon1 @edwardhorsford