-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump gulp from 4.0.2 to 5.0.0 #296
Conversation
9c59ead
to
f4e58f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This contains breaking changes. Tested it locally and for some reason it breaks the copying of images into the public folder.
Needs investigation.
1663575
to
fb37faf
Compare
@dependabot rebase |
Bumps [gulp](https://github.com/gulpjs/gulp) from 4.0.2 to 5.0.0. - [Release notes](https://github.com/gulpjs/gulp/releases) - [Changelog](https://github.com/gulpjs/gulp/blob/master/CHANGELOG.md) - [Commits](gulpjs/gulp@v4.0.2...v5.0.0) --- updated-dependencies: - dependency-name: gulp dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
fb37faf
to
4242209
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now working, thanks to the fix identified by @chrimesdev in nhsuk/nhsuk-frontend#1010 to set {encoding: false}
in the gulp task.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loaded this up locally and things seem to work ok.
Bumps gulp from 4.0.2 to 5.0.0.
Release notes
Sourced from gulp's releases.
... (truncated)
Changelog
Sourced from gulp's changelog.
... (truncated)
Commits
5c4c547
chore: Release 5.0.0 (#2762)bf72116
chore: Add index.mjs to files listb00de68
feat: Provide an ESM export (#2760)72668c6
chore!: Normalize repository, dropping node <10.13 support (#2758)85896d4
chore(docs): Update stream handbook link (#2711)818bd73
Docs: Remove gulp-sourcemaps because it is built-in (#2592)598f971
Docs: Fix broken link in recipe (#2571)9877de0
Docs: Guide CustomRegistries to maintain properties on tasks (fixes #2561) (#...f91c388
Docs: Remove typo in custom registry docs (#2543)df25250
Docs: Fix typo in task docs (#2524)You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)