Re-organise GOV.UK Notify templates #2168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This renames the labels used to reference the templates so that the mailer class actions, email and text templates all match and use a similar naming convention. This makes it easier when we come to create a log of all emails and texts to have a consistent template name to show the user.
thomasleese
force-pushed
the
govuk-notify-template-naming
branch
from
bbe7614
to
8fd33f0
Compare
|
benilovj
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames the labels used to reference the templates so that the mailer class actions, email and text templates all match and use a similar naming convention.
This makes it easier when we come to create a log of all emails and texts to have a consistent template name to show the user.
Unfortunately it's a lot of small changes, but these were mostly done automatically, but it does make it a little difficult to review the changes.