Remove references to programme teams #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
force-pushed
the
remove-references-to-teams
branch
from
85e7298
to
601592c
Compare
tvararu
approved these changes
Sep 27, 2024
thomasleese
force-pushed
the
remove-references-to-teams
branch
from
601592c
to
316b3a2
Compare
This updates models that make references to the team to use an alternative option as the relationship through the programme is being removed.
As programmes will no longer be linked to teams we need to filter on the teams separately.
The team is being removed from the programme so we need to modify any references to the programme's team with references to the current user's team.
This updates the policies to filter the objects on the teams directly rather than from the programme, which is removing the concept of programmes being attached to teams.
This adds the `has_many` relationships to the team and programme models, through the new `TeamProgramme` model.
thomasleese
force-pushed
the
remove-references-to-teams
branch
from
316b3a2
to
030674c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates various parts of the code to stop using the
teamattribute ofProgrammeas this will be being removed shortly to support global programmes. See individual commits for more details.