Replace dfe-autocomplete with accessible-autocomplete #1859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvararu
force-pushed
the
autocomplete
branch
from
cfb0dcf
to
1f4488e
Compare
tvararu
force-pushed
the
autocomplete
branch
from
1f4488e
to
dfa2d00
Compare
tvararu
force-pushed
the
autocomplete
branch
from
dfa2d00
to
adc2f62
Compare
The custom CSS seems to not be as accessible as the upstream one when using VoiceOver. It doesn't allow choosing from a list of options by swiping left/right in the focus order.
tvararu
force-pushed
the
autocomplete
branch
from
adc2f62
to
4b66cdc
Compare
The stylesheet couldn't be imported using the sass @import directive, so instead we link to it as a separate stylesheet file instead of bundling it in. This is probably more cache-friendly as the autocomplete upstream CSS will change less frequently than our application bundle CSS.
This is copied from the prototype and includes some overrides to make it align to the NHS styles better.
This allows us to specify `data-module="autocomplete"` on a `<select>` element to enhance it to an autocompleteapp/javascript/controllers/autocomplete_controller.js.
tvararu
force-pushed
the
autocomplete
branch
from
4b66cdc
to
15d6098
Compare
tvararu
force-pushed
the
autocomplete
branch
from
15d6098
to
a15d00c
Compare
Use the upstream one instead of the DFE one which has been removed.
tvararu
force-pushed
the
autocomplete
branch
from
a15d00c
to
ced5a2d
Compare
|
thomasleese
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom CSS seems to not be as accessible as the upstream one when using VoiceOver. It doesn't allow choosing from a list of options by swiping left/right in the focus order.
Add an
autocompletestimulus controller that's based on the implementation in the prototype.See commits.
Screenshots