Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update response header policy #8

Merged
merged 4 commits into from
Aug 29, 2023

Conversation

eesa456
Copy link
Contributor

@eesa456 eesa456 commented Aug 23, 2023

Description

Remove server and opennext header from cloudfront response

Context

NDOP Pen test

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@eesa456 eesa456 requested a review from Tomdango August 23, 2023 13:05
Copy link
Collaborator

@Tomdango Tomdango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall - we can just parameterise it so that any headers can be added in the future :)

locals.tf Outdated Show resolved Hide resolved
modules/opennext-cloudfront/cloudfront.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
@eesa456 eesa456 requested a review from Tomdango August 29, 2023 09:25
Copy link
Collaborator

@Tomdango Tomdango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@Tomdango Tomdango added this pull request to the merge queue Aug 29, 2023
Merged via the queue into main with commit aee2020 Aug 29, 2023
14 checks passed
@Tomdango Tomdango deleted the feature/eema1-removeServerAndOpennextHeaders branch August 29, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants