Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PriceClass variable so that it is configurable (V2) #21

Merged

Conversation

Tomdango
Copy link
Collaborator

@Tomdango Tomdango commented Feb 18, 2024

Description

This includes the changes by @andylamp with a clean Git history. It introduces two new variables to change the price class of the CloudFront distribution, and to control the cache_control values of static assets.

See #20 for more detail.

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@Tomdango Tomdango changed the title Add changes from PR 20 by @andylamp Add PriceClass variable so that it is configurable (V2) Feb 18, 2024
@Tomdango Tomdango merged commit ed3da37 into main Feb 18, 2024
14 checks passed
@Tomdango Tomdango deleted the feature/andylamp-add-configurable-cache-and-price-class branch February 18, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant