Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom waf and other fixes #11

Merged

Conversation

leonchabbey
Copy link
Contributor

Description

Adds the possibility to use a custom waf (externally created) and also fixes some minor issues.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@Tomdango
Copy link
Collaborator

Thanks for the PR! Looks like this closes #7.

@Tomdango Tomdango merged commit 2a28f92 into nhs-england-tools:main Oct 20, 2023
7 checks passed
@Tomdango Tomdango mentioned this pull request Oct 20, 2023
10 tasks
@leonchabbey leonchabbey deleted the feat/cloudfront-waf-and-fixes branch December 21, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants