Fix for NullReferenceException in lazy bidirectional many-to-one properties #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RogerKratz
pushed a commit
that referenced
this pull request
Jun 25, 2024
RogerKratz
added a commit
that referenced
this pull request
Jun 25, 2024
|
Applied! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a many-to-one bidirectional mapping with lazy properties will result in a
NullReferenceExceptioninAuditEventListener. This change to theAuditEventListenerwill fix this. There is also an accompanying unit test for this.The underlying problem that triggered the
NullReferenceExceptionwas due to the fact that the entity name could not be resolved since it was not of the expected type. The type in the case of a lazy property is a<entity name>ProxyForFieldInterceptorand not the actual type of the entity. Using the NHibernate utility methodBestGuessEntityNamewill resolve to the actual entity name thus satisfying the mapping in Envers.As I am not familiar to the Envers code base I tried to keep the
AuditEventListenerchanges minimal not to disturb the functionality. All tests passes and this fixes the problem but I'm not totally sure how the mapping actually works and thevalueargument is still of theProxyForFieldInterceptortype. Could this be a problem?