Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on MySQL 8 with MySQL8InnoDBDialect #51

Closed
wants to merge 4 commits into from

Conversation

dennis-gr
Copy link
Contributor

Run tests on MySQL 8 since 5.7 has reached EOL

@RogerKratz
Copy link
Collaborator

Thanks!
As you can see, MySQL step in pipe now fails. Can you have a look please?

@dennis-gr
Copy link
Contributor Author

Should be fixed now.

@RogerKratz
Copy link
Collaborator

still seems to be failing

@dennis-gr
Copy link
Contributor Author

Third time’s the charm ;-)

@RogerKratz
Copy link
Collaborator

Do you have any clue why mysqls tests are so much slower now?

@dennis-gr
Copy link
Contributor Author

It's most likely due to the schema creation being slower with MySQL 8 than 5.7. I did some measurements on a another project I'm working on, and the ALTER TABLE statements for foreign key creation made up about 80% of the total time spend on schema creation.

I've added another commit to put the data dir in tmpfs, which should speed up things a bit.

@dennis-gr
Copy link
Contributor Author

@RogerKratz Anything else preventing you from merging this? There's unfortunately nothing more that can be done to speed up the tests (see the discussion here for example).
If the test runtime is an issue for you, I could prepare another PR that uses MariaDB where schema creation performance is much better.

@RogerKratz
Copy link
Collaborator

thanks! squashed and rebased

@RogerKratz RogerKratz closed this Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants