-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests on MySQL 8 with MySQL8InnoDBDialect #51
Conversation
Thanks! |
…on plugin for now
Should be fixed now. |
still seems to be failing |
Third time’s the charm ;-) |
Do you have any clue why mysqls tests are so much slower now? |
It's most likely due to the schema creation being slower with MySQL 8 than 5.7. I did some measurements on a another project I'm working on, and the ALTER TABLE statements for foreign key creation made up about 80% of the total time spend on schema creation. I've added another commit to put the data dir in tmpfs, which should speed up things a bit. |
@RogerKratz Anything else preventing you from merging this? There's unfortunately nothing more that can be done to speed up the tests (see the discussion here for example). |
thanks! squashed and rebased |
Run tests on MySQL 8 since 5.7 has reached EOL