Some string.Intern's for minimizing duplicate strings count #3640
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After startup application that I develop now has ~9% of duplicate strings from all allocated objects.
1st consumer is ASP.NET MVC routing, NHib related strings seems on 2d place
and many others
Minimized by interning SimpleValue.typeName
Minimized by interning SimpleValue.identifierGeneratorStrategy
Minimized by interning in
AbstractPropertyMapping .ExtendPath
EntityMetamodel.MapIdentifierPropertyTypes
AbstractEntityPersister. InitSubclassPropertyAliasesMap
Minimized by generating suffix with interning
StringHelper.GenerateSuffix
Some minimization by interning Property.name
Some minimization by interning Property.propertyAccessorName
Minimized by interning Property.cascade
And many other similar
Some minimization by interning EnumType.typeName
Current result ~ 50K duplicates removed