Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specan fixes #799

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Specan fixes #799

merged 4 commits into from
Nov 5, 2024

Conversation

fredzo
Copy link
Contributor

@fredzo fredzo commented Nov 3, 2024

Hi Andrew,

Here is the PR for specans:

  • Adds rbw value to TimebasePropertiesDialog
  • Adapts instrument properties in StreamBrowserDialog according to HasTimebaseControls() and HasFrequencyControls() values
  • Adds missing PushIds that could lead to collisions when text/values were the same on two links.
    image

A call to GetResolutionBandwidth() and GetCenterFrequency() is made in the render method of StreamBrowserDialog.
A PR will come on scopehal to make these methods cache the value for Tek driver (which is the only one that does not cache the value).

Best,

Frederic.

Fixed potential id issues on StreamBrowserDialog.
Added support for specan properties display in StreamBrowserDialog.
@fredzo fredzo closed this Nov 4, 2024
@fredzo fredzo reopened this Nov 4, 2024
@azonenberg azonenberg merged commit e789cb2 into ngscopeclient:master Nov 5, 2024
29 checks passed
@fredzo fredzo deleted the specans-fixes branch November 5, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants