Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: deploy nightly builds #4685

Merged
merged 1 commit into from
Feb 4, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 31 additions & 5 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ jobs:
- uses: nrwl/nx-set-shas@v4
- run: pnpm exec nx run-many -t e2e --exclude=docs-app --parallel=1

build:
schematics-core-check:
runs-on: ubuntu-latest
needs: install
steps:
Expand All @@ -95,9 +95,10 @@ jobs:
cache-dependency-path: '**/pnpm-lock.yaml'
- run: pnpm install --frozen-lockfile --prefer-offline
- uses: nrwl/nx-set-shas@v4
- run: pnpm exec nx run-many -t build --exclude=docs-app
- run: pnpm run copy:schematics
- run: pnpm run schematics:check

schematics-core-check:
build:
runs-on: ubuntu-latest
needs: install
steps:
Expand All @@ -112,5 +113,30 @@ jobs:
cache-dependency-path: '**/pnpm-lock.yaml'
- run: pnpm install --frozen-lockfile --prefer-offline
- uses: nrwl/nx-set-shas@v4
- run: pnpm run copy:schematics
- run: pnpm run schematics:check
- run: pnpm exec nx run-many -t build --exclude=docs-app
- uses: actions/upload-artifact@v4
with:
name: artifact-modules
path: dist/modules

deploy:
needs: build
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0
- run: corepack enable
- uses: actions/setup-node@v4
with:
node-version-file: .node-version
cache: 'pnpm'
cache-dependency-path: '**/pnpm-lock.yaml'
- uses: actions/download-artifact@v4
with:
name: artifact-modules
path: dist
- uses: webfactory/[email protected]
with:
ssh-private-key: ${{ secrets.SSH_DEPLOY_KEY }}
- run: pnpm run deploy:builds
2 changes: 1 addition & 1 deletion build/deploy-build.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { packages } from './config';

const deploy = createBuilder([
['Deploy builds', tasks.publishToRepo],
['Deploy docs', tasks.publishDocs],
// ['Deploy docs', tasks.publishDocs],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brandonroberts do you think this is still required?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe. We use it for https://next.ngrx.io but I don't know that its heavily used

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, I haven't thought of that.
Would you be OK with doing that in a next PR? After we're sure that the current nightlies are working.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

]);

deploy({
Expand Down
Loading