refactor(signals): improve rxMethod tests by using child injectors
#4652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the tests for `rxMethod` to avoid component navigation when testing the behavior of switching injection contexts. Rename the `signalMethod` method in the testing service to `trackSignal` for better readability.
✅ Deploy Preview for ngrx-io canceled.Built without sensitive environment variables
|
Co-authored-by: Tim Deschryver <[email protected]>
markostanimirovic
approved these changes
Jan 9, 2025
|
Excellent 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the tests for
rxMethodto avoid component navigation when testing the behavior of switching injection contexts.Rename the
signalMethodmethod in the testing service totrackSignalfor better readability.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?