-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(signals): add migration for withProps
#4612
Merged
markostanimirovic
merged 6 commits into
ngrx:main
from
rainerhahnekamp:feat/store/props-migration
Dec 8, 2024
Merged
feat(signals): add migration for withProps
#4612
markostanimirovic
merged 6 commits into
ngrx:main
from
rainerhahnekamp:feat/store/props-migration
Dec 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This migration script applies to an update to version 19.0.0 RC 1. It addresses ngrx#4608, and will rename `computed` to `props` in the following scenarios: - `signalStoreFeature({computed: type<{}>())` - `signalStoreFeature(type<{computed: Signal<number>())` - `SignalStoreFeature<{computed: {}}>` - `EntityComputed` and `NamedEntityComputed`
✅ Deploy Preview for ngrx-io canceled.Built without sensitive environment variables
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 💪!
I left a few comments to make the build green
Co-authored-by: Tim Deschryver <[email protected]>
timdeschryver
approved these changes
Dec 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🫡
markostanimirovic
approved these changes
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migration script applies to an update to version 19.0.0 RC 1.
It addresses #4608, and will rename
computed
toprops
in the following scenarios:signalStoreFeature({computed: type<{}>())
signalStoreFeature(type<{computed: Signal<number>())
SignalStoreFeature<{computed: {}}>
EntityComputed
andNamedEntityComputed
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Closes #4608
Does this PR introduce a breaking change?