Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(signals): add migration for withProps #4612

Merged

Conversation

rainerhahnekamp
Copy link
Contributor

This migration script applies to an update to version 19.0.0 RC 1.
It addresses #4608, and will rename computed to props in the following scenarios:

  • signalStoreFeature({computed: type<{}>())
  • signalStoreFeature(type<{computed: Signal<number>())
  • SignalStoreFeature<{computed: {}}>
  • EntityComputed and NamedEntityComputed

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Closes #4608

Does this PR introduce a breaking change?

[ ] Yes
[x] No

This migration script applies to an update to
version 19.0.0 RC 1.
It addresses ngrx#4608, and will rename `computed` to `props`
in the following scenarios:
- `signalStoreFeature({computed: type<{}>())`
- `signalStoreFeature(type<{computed: Signal<number>())`
- `SignalStoreFeature<{computed: {}}>`
- `EntityComputed` and `NamedEntityComputed`
Copy link

netlify bot commented Dec 1, 2024

Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 9db54dd
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/67518956f4db29000883a535

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💪!
I left a few comments to make the build green

modules/signals/migrations/migration.json Outdated Show resolved Hide resolved
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@markostanimirovic markostanimirovic merged commit 5f803d0 into ngrx:main Dec 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@ngrx/signals: Add migration schematic for props
3 participants