-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(signals): add withProps
base feature
#4607
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGES: - The `computed` property in `SignalStoreFeatureResult` type is renamed to `props`. - The `EntityComputed` and `NamedEntityComputed` types in the `entities` plugin are renamed to `EntityProps` and `NamedEntityProps`. BEFORE: import { computed, Signal } from '@angular/core'; import { signalStoreFeature, SignalStoreFeature, type, withComputed, } from '@ngrx/signals'; import { EntityComputed } from '@ngrx/signals/entities'; export function withTotalEntities<Entity>(): SignalStoreFeature { state: {}, computed: EntityComputed<Entity>, methods: {} }, { state: {}, computed: { total: Signal<number> }, methods: {} }, > { return signalStoreFeature( { computed: type<EntityComputed<Entity>>() }, withComputed(({ entities }) => ({ total: computed(() => entities().length), })), ); } AFTER: import { computed, Signal } from '@angular/core'; import { signalStoreFeature, SignalStoreFeature, type, withComputed, } from '@ngrx/signals'; import { EntityProps } from '@ngrx/signals/entities'; export function withTotalEntities<Entity>(): SignalStoreFeature { state: {}, props: EntityProps<Entity>, methods: {} }, { state: {}, props: { total: Signal<number> }, methods: {} }, > { return signalStoreFeature( { props: type<EntityProps<Entity>>() }, withComputed(({ entities }) => ({ total: computed(() => entities().length), })), ); }
✅ Deploy Preview for ngrx-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Amazing work! 🎉 |
rainerhahnekamp
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Most changes are renaming to props. The main addition is withProps
with updates to withComputed
. Way to go! 👍
2 tasks
projects/ngrx.io/content/guide/signals/signal-store/private-store-members.md
Show resolved
Hide resolved
timdeschryver
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #4504
What is the new behavior?
computed
property inSignalStoreFeatureResult
type is renamed toprops
.EntityComputed
andNamedEntityComputed
types in theentities
plugin are renamed toEntityProps
andNamedEntityProps
.Does this PR introduce a breaking change?