-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(effects): update examples to standalone api #4522
docs(effects): update examples to standalone api #4522
Conversation
✅ Deploy Preview for ngrx-io ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this @AdrianRomanski
For next time, also try to add the issue number into the PR template (I've updated it now)
…ctors, add missing imports
@ timdeschryver i pushed first changes :) Tommorrow i will do the remaining |
@AdrianRomanski are you willing to address the remaining feedback? |
@timdeschryver yes, i will sit to this straight after the office |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some syntax errors, and the sections also contain references to modules.
Because I can't references as comments, I will push a few commits to resolve this.
Thanks @AdrianRomanski! |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #4468
What is the new behavior?
Does this PR introduce a breaking change?
Other information