add traffic_policy, remap policy->traffic_policy
#147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheConcierge
requested review from
andrewryno,
masonj5n,
rkolavo and
nikolay-ngrok
TheConcierge
force-pushed
the
ngrok/ryan/traffic-polilcy
branch
from
a0acd30 to
8741ac6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Currently, we are in the process of erasing strict policy types from our SDKs. This changes makes sure policy is sent to the backend as a traffic_policy string as opposed to a strictly formatted policy struct.
How
The traffic policy field already exists and functions in the underlying rust SDK. So all we have to do is plumb the new field through to Rust. Additionally, instances of Policy are remapped to traffic policy.
Validation
Current unit tests continue to run.
An additional unit test was added using the new TrafficPolicy field.
Additional Changes
Rust LSP
To make development easier, I added the rust SDK to our nix flake.
Adding
mioto theudepsignore listcargo udepskeeps claiming that it is unused. However, if I remove it, everything implodes.I keep seeing stuff about
udepshaving false positives so i just decided to ignore it. We have done a similar thing in the Python API.