Fix coverage #91
Merged
Fix coverage #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overall cov now at 96%, code_eT_zhz 79% Todo: refine testing further
update to testing and dev branches workflow
This was
linked to
issues
Jun 28, 2022
Closed
This was
linked to
issues
Jun 28, 2022
|
I'm going to add a commit resolving #90 to the head of this branch |
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
===========================================
+ Coverage 93.79% 100.00% +6.20%
===========================================
Files 10 10
Lines 3675 3540 -135
===========================================
+ Hits 3447 3540 +93
+ Misses 228 0 -228 |
ngraymon
reviewed
Jun 29, 2022
|
|
||
| # for each t term add 1 electronic label | ||
| electronic_components += ['a', ] * len(t_list) | ||
| # the dT term has 1 electronic components |
There was a problem hiding this comment.
At first I thought there was an issue in lines 127-136 and you deleted some code but I think its just git incorrectly recognizing the line changes
There was a problem hiding this comment.
Ah okay this can be fixed by adding an empty line after the else statement
`_handle_multiline_same_prefactor` `_collect_z_contributions`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.