Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix icpc pybind11. #173

Closed
wants to merge 3 commits into from
Closed

Fix icpc pybind11. #173

wants to merge 3 commits into from

Conversation

s-mandra
Copy link
Member

The easiest way to fix this was to actually use g++ for pybind11 instead of icpc. Since the library are already compiled with icpc, performance shouldn't be affected.

dagart added 3 commits October 24, 2019 08:39
@dagart
Pybind11 only includes relevant headers.
2cf6057
@dagart
Pybind11 only includes relevant headers.
28f7f88
@dagart
Pybind11 link is done using g++ (not $(CXX)).
5d79f3d 
This fixes some compilation issues using icpc, and most likely using other compilers as well.
@s-mandra s-mandra added this to the qFlex initial release milestone Oct 24, 2019
@s-mandra s-mandra self-assigned this Oct 24, 2019
@s-mandra
Copy link
Member Author

Fixes #171.

@s-mandra s-mandra closed this Oct 24, 2019
@s-mandra
Copy link
Member Author

One test fails because of linking issues.

@s-mandra s-mandra deleted the fix-icpc-pybind11 branch October 24, 2019 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandrupaler alexandrupaler Awaiting requested review from alexandrupaler

@95-martin-orion 95-martin-orion Awaiting requested review from 95-martin-orion

Assignees

@s-mandra s-mandra

Labels
None yet
Projects
None yet
Milestone
qFlex initial release
Development

Successfully merging this pull request may close these issues.
2 participants
@s-mandra @dagart