Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for IE11 #993

Merged
merged 7 commits into from
Oct 11, 2023
Merged

Conversation

HHongSeungWoo
Copy link
Contributor

IE11 is deprecated.
This change will save a lot of bundle size.

@HHongSeungWoo HHongSeungWoo changed the title Remove support ie11 Remove support for IE11 Jul 1, 2023
@papillot
Copy link
Contributor

papillot commented Jul 2, 2023

Thanks for looking into this!
Do you by any chance have any metrics on the before/after regarding the bundle size?

Also, it looks like a good idea to remove the polyfills as well. I've been through the list and noted that they polyfill IE only missing feature (in other words these features were implemented circa 2015 or before)

Also, what is the consequence of removing buble? Is there any kind of transpilation yet? What will be the final code compatibility target?

@HHongSeungWoo
Copy link
Contributor Author

HHongSeungWoo commented Jul 2, 2023

@papillot

Compare bundle sizes

egl.esm.js: 760kb -> 677kb
ngl.js: 1.2mb -> 1.1mb
ngl.umd.js: 765kb -> 682kb

The bubble compiler seems to exist to support ES6 syntax in IE11. Browsers that don't support ES6 are currently deprecated, so it should provide the same compatibility as before.

@HHongSeungWoo
Copy link
Contributor Author

@papillot Could you please review this PR?

@ppillot
Copy link
Collaborator

ppillot commented Oct 9, 2023

@HHongSeungWoo I'll make my best to finalize this in the upcoming days.
Would you mind removing the build commits from your PR (git rebase -i and remove the two build commits) ? We'll update dist for the next released version and in the mean time we try to avoid commits with build files in them. Thank-you for your contribution.

Copy link
Collaborator

@ppillot ppillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements.
Will do a release with these changes soon.

@ppillot ppillot merged commit 57c0362 into nglviewer:master Oct 11, 2023
2 checks passed
@HHongSeungWoo HHongSeungWoo deleted the remove_support_ie11 branch October 28, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants