Fix banding appearing after antialiasing

A banding effect was due to a loss of precision when copying the texture between render targets as linear encoding requires more precision.
nglviewer · Dec 24, 2023 · c26827e · c26827e
1 parent 54363c1
commit c26827e
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/src/viewer/viewer.ts b/src/viewer/viewer.ts
@@ -16,7 +16,8 @@ import {
   Scene, Mesh, Group, Object3D, Uniform,
   Fog, DirectionalLight, AmbientLight,
   BufferGeometry, BufferAttribute,
-  LineSegments
+  LineSegments,
+  HalfFloatType
 } from 'three'
 import '../shader/BasicLine.vert'
 import '../shader/BasicLine.frag'
@@ -511,7 +512,10 @@ export default class Viewer {
       {
         minFilter: LinearFilter,
         magFilter: LinearFilter,
-        format: RGBAFormat
+        format: RGBAFormat,
+        type: this.supportsHalfFloat ? HalfFloatType : (
+          SupportsReadPixelsFloat ? FloatType : UnsignedByteType
+        )
       }
     )
 
@@ -521,11 +525,9 @@ export default class Viewer {
         minFilter: NearestFilter,
         magFilter: NearestFilter,
         format: RGBAFormat,
-        type: UnsignedByteType
-        // using HalfFloatType or FloatType does not work on some Chrome 61 installations
-        // type: this.supportsHalfFloat ? HalfFloatType : (
-        //   SupportsReadPixelsFloat ? FloatType : UnsignedByteType
-        // )
+        type: this.supportsHalfFloat ? HalfFloatType : (
+          SupportsReadPixelsFloat ? FloatType : UnsignedByteType
+        )
       }
     )