-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CP/DP Split: Remove NGINX manager and deployment #2936
base: change/control-data-plane-split
Are you sure you want to change the base?
CP/DP Split: Remove NGINX manager and deployment #2936
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## change/control-data-plane-split #2936 +/- ##
===================================================================
+ Coverage 89.93% 90.50% +0.56%
===================================================================
Files 111 105 -6
Lines 11421 10979 -442
Branches 50 50
===================================================================
- Hits 10271 9936 -335
+ Misses 1089 990 -99
+ Partials 61 53 -8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my review for a small nit, but otherwise LGTM
nit: I see comments in various places using |
Removing the nginx runtime manager and deployment container since nginx will live in its own pod managed by agent. Temporarily saving the nginx deployment and service for future use. Updated the control plane liveness probe to return true once it's processed all resources, instead of after it's written config to nginx (since nginx may not be started yet in the future architecture).
09b399d
to
cdb28c7
Compare
I don't feel strongly about the wording in this case |
Removing the nginx runtime manager and deployment container since nginx will live in its own pod managed by agent. Temporarily saving the nginx deployment and service for future use.
Updated the control plane liveness probe to return true once it's processed all resources, instead of after it's written config to nginx (since nginx may not be started yet in the future architecture).
Testing: Verified that the control plane is able to start and run on its own.
Closes #2838