Add SnippetsFilter guide #2721
Merged
Add SnippetsFilter guide #2721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
bjee19
commented
Oct 23, 2024
bjee19
commented
Oct 23, 2024
bjee19
commented
Oct 23, 2024
ADubhlaoich
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
LGTM generally: I'd consider using the ghcode shortcode to explicitly show the YAML contents of files, but it might lead to reading fatigue.
Using it for the code that includes the actual snippets could show the reader what to expect if they decide to configure NGF with them, at least.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2721 +/- ##
=======================================
Coverage 89.40% 89.40%
=======================================
Files 110 110
Lines 10913 10913
Branches 50 50
=======================================
Hits 9757 9757
Misses 1098 1098
Partials 58 58 ☔ View full report in Codecov by Sentry. |
sjberman
reviewed
Oct 24, 2024
sjberman
reviewed
Oct 24, 2024
sjberman
reviewed
Oct 24, 2024
bjee19
commented
Oct 24, 2024
sjberman
reviewed
Oct 25, 2024
ADubhlaoich
approved these changes
Oct 29, 2024
kate-osborn
requested changes
Oct 29, 2024
There was a problem hiding this comment.
Great work on this @bjee19. Sorry to jump in late with comments.
salonichf5
requested changes
Oct 29, 2024
kate-osborn
requested changes
Oct 30, 2024
kate-osborn
approved these changes
Oct 31, 2024
sjberman
reviewed
Nov 5, 2024
bjee19
force-pushed
the
docs/sf-guide
branch
from
1b973ea
to
e52c227
Compare
sjberman
approved these changes
Nov 12, 2024
bjee19
force-pushed
the
docs/sf-guide
branch
from
e52c227
to
ffd09a4
Compare
salonichf5
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SnippetsFilters guide.
Problem: We want a guide for using SnippetsFilters.
Solution: Add a SnippetsFilters guide.
Testing: Verified using
make watchHugo command.Closes #2377
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.