Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove marketplace plus images from docs for 4.0.0 #6928

Merged
merged 4 commits into from
Dec 6, 2024
Merged

Remove marketplace plus images from docs for 4.0.0 #6928

merged 4 commits into from
Dec 6, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Dec 6, 2024 •
edited
Loading

Proposed changes

Remove marketplace plus images from technical specs documentation

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested review from a team as code owners December 6, 2024 13:24
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Dec 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/6928/

@github-actions github-actions bot added the chore Pull requests for routine tasks label Dec 6, 2024
@pdabelf5 pdabelf5 requested review from vepatel and j1m-ryan December 6, 2024 13:48
@github-actions github-actions bot removed the chore Pull requests for routine tasks label Dec 6, 2024
@pdabelf5 pdabelf5 merged commit 25805f9 into main Dec 6, 2024
32 checks passed
@pdabelf5 pdabelf5 deleted the docs-marketplace-r33 branch December 6, 2024 15:27
@pdabelf5 pdabelf5 changed the title remove marketplace plus images from docs for 4.0.0 Remove marketplace plus images from docs for 4.0.0 Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel Awaiting requested review from vepatel

@j1m-ryan j1m-ryan Awaiting requested review from j1m-ryan

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pdabelf5 @j1m-ryan @vepatel