Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional mgmt config parameters #6921

Merged
merged 14 commits into from
Dec 6, 2024
Merged

Add additional mgmt config parameters #6921

merged 14 commits into from
Dec 6, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Dec 5, 2024

Proposed changes

Add mgmt parameters for

controller.mgmt.usageReport.endpoint
controller.mgmt.usageReport.interval
controller.mgmt.sslVerify
controller.mgmt.resolver.ipv6
controller.mgmt.resolver.valid
controller.mgmt.resolver.addresses
controller.mgmt.sslCertificateSecretName
controller.mgmt.sslTrustedCertificateSecretName
controller.mgmt.configMapName

Docs Additions:

  • Adds Mgmt ConfigMap page
  • Adds Helm Values to Installation with Helm Page
  • Command Line Argument Addition
  • Create License Secret Page

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner December 5, 2024 12:57
@github-actions github-actions bot added documentation Pull requests/issues for documentation go Pull requests that update Go code python Pull requests that update Python code tests Pull requests that update tests helm_chart Pull requests that update the Helm Chart labels Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 8.05369% with 137 lines in your changes missing coverage. Please review.

Project coverage is 52.66%. Comparing base (39b285d) to head (d3d2b5a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/configs/configmaps.go 15.25% 42 Missing and 8 partials ⚠️
cmd/nginx-ingress/main.go 0.00% 43 Missing ⚠️
internal/k8s/controller.go 0.00% 36 Missing ⚠️
internal/configs/configurator.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6921      +/-   ##
==========================================
- Coverage   52.95%   52.66%   -0.29%     
==========================================
  Files          88       88              
  Lines       20591    20758     +167     
==========================================
+ Hits        10903    10933      +30     
- Misses       9239     9370     +131     
- Partials      449      455       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j1m-ryan j1m-ryan requested a review from a team as a code owner December 6, 2024 10:44
Copy link

github-actions bot commented Dec 6, 2024

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/6921/

Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM. I made a bunch of edit suggestions around sentence case and generic noun usage: if everything is capitalized, everything reads like some kind of unique feature to NGINX Ingress Controller, as opposed to a concept or artefact people are likely already familiar with.

@pdabelf5 pdabelf5 merged commit b4c2317 into main Dec 6, 2024
32 checks passed
@pdabelf5 pdabelf5 deleted the additional-mgmt-params branch December 6, 2024 13:08
@pdabelf5 pdabelf5 removed the documentation Pull requests/issues for documentation label Dec 13, 2024
@pdabelf5 pdabelf5 added enhancement Pull requests for new features/feature enhancements and removed go Pull requests that update Go code python Pull requests that update Python code tests Pull requests that update tests helm_chart Pull requests that update the Helm Chart labels Dec 13, 2024
@pdabelf5 pdabelf5 changed the title add additional mgmt config parameters Add additional mgmt config parameters Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

6 participants