-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional mgmt config parameters #6921
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6921 +/- ##
==========================================
- Coverage 52.95% 52.66% -0.29%
==========================================
Files 88 88
Lines 20591 20758 +167
==========================================
+ Hits 10903 10933 +30
- Misses 9239 9370 +131
- Partials 449 455 +6 ☔ View full report in Codecov by Sentry. |
✅ Deploy Preview will be available once build job completes!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM. I made a bunch of edit suggestions around sentence case and generic noun usage: if everything is capitalized, everything reads like some kind of unique feature to NGINX Ingress Controller, as opposed to a concept or artefact people are likely already familiar with.
site/content/installation/installing-nic/create-license-secret.md
Outdated
Show resolved
Hide resolved
site/content/installation/installing-nic/create-license-secret.md
Outdated
Show resolved
Hide resolved
site/content/installation/installing-nic/create-license-secret.md
Outdated
Show resolved
Hide resolved
site/content/installation/installing-nic/create-license-secret.md
Outdated
Show resolved
Hide resolved
site/content/installation/installing-nic/create-license-secret.md
Outdated
Show resolved
Hide resolved
site/content/installation/installing-nic/create-license-secret.md
Outdated
Show resolved
Hide resolved
site/content/installation/installing-nic/create-license-secret.md
Outdated
Show resolved
Hide resolved
site/content/installation/installing-nic/create-license-secret.md
Outdated
Show resolved
Hide resolved
site/content/installation/installing-nic/create-license-secret.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Alan Dooley <[email protected]> Signed-off-by: Jim Ryan <[email protected]>
Proposed changes
Add mgmt parameters for
Docs Additions:
Checklist
Before creating a PR, run through this checklist and mark each as complete.