Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license secret and mgmt config map for r33 #6903

Merged
merged 29 commits into from
Dec 4, 2024

Conversation

AlexFenlon
Copy link
Contributor

@AlexFenlon AlexFenlon commented Dec 3, 2024

Proposed changes

add initial r33 commit adds license token secret name and mgmt config map.
add app protect 5.4

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@AlexFenlon AlexFenlon requested review from a team as code owners December 3, 2024 16:43
@github-actions github-actions bot added documentation Pull requests/issues for documentation change Pull requests that introduce a change go Pull requests that update Go code python Pull requests that update Python code github_actions Pull requests that update Github_actions code docker Pull requests that update Docker code labels Dec 3, 2024
@github-actions github-actions bot added chore Pull requests for routine tasks tests Pull requests that update tests helm_chart Pull requests that update the Helm Chart labels Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/6903/

@AlexFenlon
Copy link
Contributor Author

All feedback on the previous pr has been addressed

Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 31.81818% with 150 lines in your changes missing coverage. Please review.

Project coverage is 52.94%. Comparing base (97055e4) to head (77b94c7).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
internal/k8s/controller.go 1.66% 57 Missing and 2 partials ⚠️
cmd/nginx-ingress/main.go 0.00% 46 Missing ⚠️
internal/k8s/configmap.go 0.00% 21 Missing ⚠️
internal/configs/configurator.go 70.37% 6 Missing and 2 partials ⚠️
cmd/nginx-ingress/flags.go 0.00% 7 Missing ⚠️
...l/configs/commonhelpers/common_template_helpers.go 0.00% 5 Missing ⚠️
internal/configs/version1/template_helper.go 0.00% 2 Missing ⚠️
internal/k8s/secrets/validation.go 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6903      +/-   ##
==========================================
- Coverage   53.15%   52.94%   -0.22%     
==========================================
  Files          88       88              
  Lines       20396    20595     +199     
==========================================
+ Hits        10842    10903      +61     
- Misses       9111     9243     +132     
- Partials      443      449       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexFenlon AlexFenlon enabled auto-merge (squash) December 4, 2024 10:52
@AlexFenlon AlexFenlon merged commit 4ad1350 into main Dec 4, 2024
72 of 73 checks passed
@AlexFenlon AlexFenlon deleted the change/add-mgmt-license-and-configmap branch December 4, 2024 12:15
@pdabelf5 pdabelf5 changed the title add license secret and mgmt config map for r33 Add license secret and mgmt config map for r33 Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change Pull requests that introduce a change chore Pull requests for routine tasks docker Pull requests that update Docker code documentation Pull requests/issues for documentation github_actions Pull requests that update Github_actions code go Pull requests that update Go code helm_chart Pull requests that update the Helm Chart python Pull requests that update Python code tests Pull requests that update tests
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

5 participants