Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues reported by staticcheck #6415

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Fix issues reported by staticcheck #6415

merged 3 commits into from
Sep 13, 2024

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Sep 13, 2024

Proposed changes

This PR addresses errors reported by staticcheck (printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006))

➜  kubernetes-ingress git:(chore/staticcheck) ✗ staticcheck --version
staticcheck 2024.1.1 (0.5.1)
staticcheck ./...
internal/certmanager/sync_test.go:522:5: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
internal/certmanager/test_files/context_builder.go:177:3: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
internal/certmanager/test_files/context_builder.go:180:3: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
internal/configs/virtualserver_test.go:1482:3: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
internal/configs/virtualserver_test.go:1789:3: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
internal/configs/virtualserver_test.go:2095:3: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
internal/configs/virtualserver_test.go:2399:3: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
internal/configs/virtualserver_test.go:6350:5: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
internal/configs/virtualserver_test.go:6354:5: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
internal/configs/virtualserver_test.go:6358:5: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
internal/configs/virtualserver_test.go:6362:5: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
internal/configs/virtualserver_test.go:7164:5: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
internal/configs/virtualserver_test.go:15806:5: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
internal/externaldns/sync_test.go:85:5: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
internal/externaldns/sync_test.go:88:5: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
internal/k8s/appprotect/app_protect_configuration.go:211:89: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
internal/k8s/appprotect/app_protect_configuration.go:218:89: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
internal/k8s/appprotect/app_protect_configuration.go:227:92: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
internal/k8s/appprotect/app_protect_configuration.go:246:20: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
internal/k8s/appprotect/app_protect_configuration.go:254:20: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
internal/k8s/appprotect/app_protect_configuration.go:281:84: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
internal/k8s/appprotect/app_protect_configuration.go:293:74: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
internal/k8s/validation.go:971:10: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
pkg/apis/configuration/validation/common.go:24:10: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner September 13, 2024 08:54
@github-actions github-actions bot added the go Pull requests that update Go code label Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 53.20%. Comparing base (45d3f46) to head (06d90e1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/certmanager/test_files/context_builder.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6415      +/-   ##
==========================================
- Coverage   53.23%   53.20%   -0.03%     
==========================================
  Files          85       85              
  Lines       16002    16002              
==========================================
- Hits         8518     8514       -4     
- Misses       7079     7081       +2     
- Partials      405      407       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jjngx jjngx merged commit 0432a95 into main Sep 13, 2024
78 checks passed
@jjngx jjngx deleted the chore/staticcheck branch September 13, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

3 participants