Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ip as an option to listeners for TransportServer #6367

Merged
merged 17 commits into from
Sep 17, 2024

Conversation

j1m-ryan
Copy link
Contributor

@j1m-ryan j1m-ryan commented Sep 6, 2024

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to
that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added enhancement Pull requests for new features/feature enhancements documentation Pull requests/issues for documentation go Pull requests that update Go code labels Sep 6, 2024
Copy link

github-actions bot commented Sep 6, 2024

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/6367/

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 6 lines in your changes missing coverage. Please review.

Project coverage is 53.24%. Comparing base (166b954) to head (72004cf).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/k8s/transport_server.go 0.00% 3 Missing ⚠️
internal/k8s/controller.go 0.00% 2 Missing ⚠️
internal/k8s/global_configuration.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6367      +/-   ##
==========================================
+ Coverage   53.20%   53.24%   +0.03%     
==========================================
  Files          85       85              
  Lines       16002    16015      +13     
==========================================
+ Hits         8514     8527      +13     
- Misses       7081     7082       +1     
+ Partials      407      406       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j1m-ryan j1m-ryan changed the title add ip to transportserver listener Add IP to TransportServer Listener Sep 6, 2024
@github-actions github-actions bot added the helm_chart Pull requests that update the Helm Chart label Sep 10, 2024
@j1m-ryan j1m-ryan force-pushed the feat/transport-server-ip-listeners branch from 6cb84a4 to 9932dd4 Compare September 10, 2024 16:19
@github-actions github-actions bot added python Pull requests that update Python code tests Pull requests that update tests labels Sep 11, 2024
@j1m-ryan j1m-ryan marked this pull request as ready for review September 17, 2024 13:30
@j1m-ryan j1m-ryan requested review from a team as code owners September 17, 2024 13:30
@vepatel vepatel linked an issue Sep 17, 2024 that may be closed by this pull request
@j1m-ryan j1m-ryan merged commit b091bad into main Sep 17, 2024
32 checks passed
@j1m-ryan j1m-ryan deleted the feat/transport-server-ip-listeners branch September 17, 2024 15:00
@pdabelf5 pdabelf5 changed the title Add IP to TransportServer Listener Add ip as an option to listeners for TransportServer Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements go Pull requests that update Go code helm_chart Pull requests that update the Helm Chart python Pull requests that update Python code tests Pull requests that update tests
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

Extend ip as an option to listeners for TransportServer
4 participants