Clarifying scope of charts #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating to identify that underlying apps may not be open source
lucacome
reviewed
Jan 27, 2023
Comment on lines
+5
to
+7
| NGINX Ingress Controller | ||
| NGINX Service Mesh | ||
| NGINX Appprotect Dos Arbitrator |
There was a problem hiding this comment.
Shouldn't this still be a list? Also since you're updating this section there are more charts in the repo now that are not listed.
There was a problem hiding this comment.
This repo is also serving several NGINX Management Suite packages. I can submit a PR tomorrow to add those to this list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating to identify that underlying apps may not be open source, Per discussion with Maryna