Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include a "standard" link to the list of discussions #153

Merged
merged 3 commits into from
Jul 1, 2024

Conversation

mjang
Copy link
Collaborator

@mjang mjang commented Jun 3, 2024

I've done some hard coding. (I couldn't figure out how to set this up "properly." But since this applies to all pages, I'm not sure if that matters.)

I don't claim to know any/all PR requirements -- I'm using this as a learning experience.

Ref #150 and nginx/unit#1299

Here's how it looks in the local build.
Screenshot 2024-06-03 at 2 02 05 PM

Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for nginx-unit ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 19c94d4
🔍 Latest deploy log https://app.netlify.com/sites/nginx-unit/deploys/667800e79ac5900008c3915c
😎 Deploy Preview https://deploy-preview-153--nginx-unit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mjang mjang requested a review from danielledeleo June 10, 2024 16:19
@mjang mjang self-assigned this Jun 10, 2024
@callahad
Copy link
Collaborator

Somehow missed this in my review queue. Would love to replace the icon with either a GitHub logo or chat bubbles from Font Awesome and tweak the text to be more along the lines of "Discuss on GitHub" or similar.

@mjang
Copy link
Collaborator Author

mjang commented Jun 14, 2024

... Would love to replace the icon with either a GitHub logo or chat bubbles from Font Awesome and tweak the text to be more along the lines of "Discuss on GitHub" or similar.

I hear you, @callahad. However, finding where to add such icons is beyond my expertise, as I'm not familiar with how this is set up. My research suggests that this is loosely based on astropy/astropy#347.

I hard coded the link because my understanding is that we're planning to move this content to the new documentation tools that @danielledeleo and cohorts are working on. (If I'm mistaken, then I would also have to defer to their expertise on where to include something like the GH octocat icon in this repo.)

@lcrilly
Copy link
Contributor

lcrilly commented Jun 14, 2024

@callahad, would an emoji suffice? 💬

@callahad
Copy link
Collaborator

callahad commented Jun 14, 2024

I'll slap in the fa svg tonight

@callahad
Copy link
Collaborator

Pushed a patch so this now renders as:

Screenshot 2024-06-23 at 11 58 26

@callahad callahad requested a review from avahahn July 1, 2024 15:53
Copy link
Contributor

@avahahn avahahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@callahad callahad merged commit cf1d8d3 into nginx:main Jul 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants