-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include a "standard" link to the list of discussions #153
Conversation
✅ Deploy Preview for nginx-unit ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Somehow missed this in my review queue. Would love to replace the icon with either a GitHub logo or chat bubbles from Font Awesome and tweak the text to be more along the lines of "Discuss on GitHub" or similar. |
I hear you, @callahad. However, finding where to add such icons is beyond my expertise, as I'm not familiar with how this is set up. My research suggests that this is loosely based on astropy/astropy#347. I hard coded the link because my understanding is that we're planning to move this content to the new documentation tools that @danielledeleo and cohorts are working on. (If I'm mistaken, then I would also have to defer to their expertise on where to include something like the GH octocat icon in this repo.) |
@callahad, would an emoji suffice? 💬 |
I'll slap in the fa svg tonight |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I've done some hard coding. (I couldn't figure out how to set this up "properly." But since this applies to all pages, I'm not sure if that matters.)
I don't claim to know any/all PR requirements -- I'm using this as a learning experience.
Ref #150 and nginx/unit#1299
Here's how it looks in the local build.