Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix COPY error #101

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix COPY error #101

wants to merge 1 commit into from

Conversation

dradetsky
Copy link

If you aren't using buildx, the instruction COPY *.patch . fails due to not being able to copy anything to the container.

@lcrilly
Copy link
Collaborator

lcrilly commented Nov 5, 2024

Given that COPY . /var/www would already include any .patch files I think it better just to remove the COPY *.patch . line.

Can you please test/confirm in your environment?

@dradetsky
Copy link
Author

@lcrilly I agree

@lcrilly
Copy link
Collaborator

lcrilly commented Nov 6, 2024

And now we don't need the new null.patch file ;)

@dradetsky
Copy link
Author

@lcrilly did I not delete that file in my last commit? It says I did.

@lcrilly
Copy link
Collaborator

lcrilly commented Nov 6, 2024

Must have been my browser cache. Looks good now.

Please see style notes for the commit message
https://github.com/nginx/nginx.org?tab=readme-ov-file#style-guide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants