Skip to content

Generate all CRDs, update RBAC, fix Alpine tag #3538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: feat/nap-waf
Choose a base branch
from

Conversation

ciarams87
Copy link
Contributor

Proposed changes

Problem: The CRD generation is incomplete, the Alpine image tag was inadvertently removed during a rebase, and the RBAC needs to be updated to allow the controller to watch for the WAFPolicies and their status

Solution: Add these changes

Testing: Describe any testing that you did.

Please focus on (optional): I'm adding these changes in a separate PR to make the WAFPolicy controller PR less cluttered.

Related: #3532

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@ciarams87 ciarams87 requested a review from a team as a code owner June 24, 2025 10:04
@github-actions github-actions bot added enhancement New feature or request helm-chart Relates to helm chart labels Jun 24, 2025
@ciarams87 ciarams87 force-pushed the feat/waf-policy-crds branch from 2818ae6 to 111dbda Compare June 24, 2025 10:28
@ciarams87 ciarams87 removed the enhancement New feature or request label Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helm-chart Relates to helm chart
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

2 participants