Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't cancel in progress runs of CLA bot #2521

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Sep 6, 2024

Proposed changes

We have a bot that adds comments to the community PRs and triggers a second run of the workflow right away. This means that the first run that was actually checking the CLA gets canceled and the check doesn't run.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@lucacome lucacome requested a review from a team as a code owner September 6, 2024 19:04
@github-actions github-actions bot added the chore Pull requests for routine tasks label Sep 6, 2024
@lucacome lucacome enabled auto-merge (squash) September 6, 2024 19:13
@lucacome lucacome merged commit 6b9ad3a into nginx:main Sep 6, 2024
38 checks passed
@lucacome lucacome deleted the chore/cla branch September 12, 2024 17:21
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
We have a bot that adds comments to the community PRs and triggers a second run of the workflow right away. This means that the first run that was actually checking the CLA gets canceled and the check doesn't run.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants