Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NGF telemetry data for TLSRoute #2359

Conversation

sarthyparty
Copy link
Contributor

@sarthyparty sarthyparty commented Aug 9, 2024

Proposed changes

Problem: NGF did not support telemetry for TLSRoute

Solution: I counted the number of TLSRoutes in the graph and added it to the telemetry data

Testing: Added unit tests for the updated code

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #2286

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


Problem: NGF did not support telemetry for TLSRoute

Solution: I counted the number of TLSRoutes in the
graph and added it to the telemetry data
@sarthyparty sarthyparty requested a review from a team as a code owner August 9, 2024 17:16
@github-actions github-actions bot added the chore Pull requests for routine tasks label Aug 9, 2024
@sarthyparty sarthyparty requested a review from a team as a code owner August 9, 2024 17:32
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 9, 2024
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.89%. Comparing base (8753459) to head (cb9195c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2359      +/-   ##
==========================================
+ Coverage   88.88%   88.89%   +0.01%     
==========================================
  Files         100      100              
  Lines        7509     7518       +9     
  Branches       50       50              
==========================================
+ Hits         6674     6683       +9     
  Misses        780      780              
  Partials       55       55              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc changes LGTM but as they are minor and the scope of the PR is largely code related, I am not giving an approval.

@bjee19
Copy link
Contributor

bjee19 commented Aug 13, 2024

Closing this PR and moving work to #2387.

@bjee19 bjee19 closed this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Telemetry: Report number of TLSRoutes
4 participants