Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new action to build + push to azure #2152

Closed
wants to merge 2 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions .github/workflows/build-push.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
name: Build + Push to Azure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add "docs" to this name (and the name of the file itself) so it's clear what this is for? (and not the product).


on:
workflow_dispatch:
inputs:
branch:
description: "Source branch to deploy"
required: false
default: "main"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think source branch should be required, and not default to main. This way someone doesn't accidentally publish our docs from the main branch, since we want our published docs to always be from a release branch.

type: string
environment:
description: "Determines where build gets pushed to"
required: false
default: "preview"
type: choice
options:
- preview
- dev
- staging
- prod
push:
branches:
- main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the comment above, I'm assuming this is going to publish our public docs for every push to main? if so, we don't want that behavior, we only publish from our latest release branch.

paths:
- nginx-gateway-fabric/site/content
pull_request:
branches:
- "*"
jobs:
call-docs-build-push:
uses: nginxinc/docs-actions/.github/workflows/docs-build-push.yml@main
with:
production_url_path: "/nginx-gateway-fabric"
preview_url_path: "/previews/nginx-gateway-fabric/"
docs_source_path: "./site/content/"
docs_build_path: "./site/"
doc_type: "hugo"
secrets:
AZURE_CREDENTIALS: ${{secrets.AZURE_CREDENTIALS}}
AZURE_KEY_VAULT: ${{secrets.AZURE_KEY_VAULT}}
Loading