Skip to content

Commit

Permalink
Add retries to tracing tests (#2101)
Browse files Browse the repository at this point in the history
Problem: The tracing tests are still flaky as to whether or not the traces properly show up. The issues isn't really know right now.

Solution: Add retries to the test in an attempt to remediate the intermittent issue.
  • Loading branch information
sjberman authored Jun 5, 2024
1 parent 23f75a4 commit c5f8dbe
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion tests/suite/tracing_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,10 @@ import (
"github.com/nginxinc/nginx-gateway-fabric/tests/framework"
)

var _ = Describe("Tracing", Label("functional", "tracing"), func() {
// This test can be flaky when waiting to see traces show up in the collector logs.
// Sometimes they get there right away, sometimes it takes 30 seconds. Retries were
// added to attempt to mitigate the issue, but it didn't fix it 100%
var _ = Describe("Tracing", FlakeAttempts(2), Label("functional", "tracing"), func() {
var (
files = []string{
"hello-world/apps.yaml",
Expand Down

0 comments on commit c5f8dbe

Please sign in to comment.