Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS template test tidy up #7211

Merged
merged 14 commits into from
Jan 27, 2025
Merged

VS template test tidy up #7211

merged 14 commits into from
Jan 27, 2025

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Jan 24, 2025

Proposed changes

Update the VS template tests to use more concise setups for the test. This makes the test more readable for future users & test writers

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner January 24, 2025 16:12
@github-actions github-actions bot added the go Pull requests that update Go code label Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.72%. Comparing base (ae73e34) to head (9e0bc6f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7211      +/-   ##
==========================================
- Coverage   52.73%   52.72%   -0.02%     
==========================================
  Files          89       89              
  Lines       20843    20843              
==========================================
- Hits        10992    10989       -3     
- Misses       9394     9396       +2     
- Partials      457      458       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 added the chore Pull requests for routine tasks label Jan 24, 2025
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@github-actions github-actions bot removed the chore Pull requests for routine tasks label Jan 27, 2025
@pdabelf5 pdabelf5 merged commit 65b2d52 into main Jan 27, 2025
71 checks passed
@pdabelf5 pdabelf5 deleted the template-test-tidy branch January 27, 2025 14:38
pdabelf5 added a commit that referenced this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

3 participants